[coreboot-gerrit] [L] Change in coreboot[master]: device/dram: add DDR4 MRS commands

[Martin L Roth (Code Review)]

Attention is currently required from: Andrey Petrov, David Hendricks, Matt DeVillier, Michał Żygowski, Paul Menzel, Sergii Dmytruk.

Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67059?usp=email )

Change subject: device/dram: add DDR4 MRS commands
......................................................................

Patch Set 11: Code-Review+2

(1 comment)

File src/include/device/dram/ddr4.h:

https://review.coreboot.org/c/coreboot/+/67059/comment/9af0b0c7_f0ceefb5 :
PS11, Line 106: typedef u32 mrs_cmd_t;
Nit: We prefer not to use typedefs unless there's a specific reason to.

https://doc.coreboot.org/contributing/coding_style.html#typedefs

I'll leave it up to you whether there's a specific reason here, but I didn't see a reason that u32 or uint32_t couldn't be used.

Since this (at worst) is a minor coding style violation, so feel free to fix it in a follow-on patch as well if you desire.