Attention is currently required from: Jason Glenesk, Raul Rangel, Marshall Dawson, Karthik Ramasubramanian.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52911 )
Change subject: soc/amd/common/fsp/pci: Add helper methods for PCI IRQ table
......................................................................
Patch Set 2:
(2 comments)
Patchset:
PS2:
only did half of a review on this one
File src/soc/amd/common/fsp/pci/pci_routing_info.c:
https://review.coreboot.org/c/coreboot/+/52911/comment/b2e27d67_94055f4f
PS2, Line 24: static const struct pci_routing_info *routing_table;
: static size_t routing_table_entries;
move those inside get_pci_routing_tablen so they won't be visible outside of that function, since that function should always be used as the accessor
--
To view, visit
https://review.coreboot.org/c/coreboot/+/52911
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id03d0b74ca12e7bcee11f8d13b0e802861c13923
Gerrit-Change-Number: 52911
Gerrit-PatchSet: 2
Gerrit-Owner: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Comment-Date: Wed, 05 May 2021 21:42:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment