Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34779 )
Change subject: mb/lenovo/t60: Switch to override tree ......................................................................
Patch Set 3:
(7 comments)
https://review.coreboot.org/c/coreboot/+/34779/3/src/mainboard/lenovo/t60/de... File src/mainboard/lenovo/t60/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/34779/3/src/mainboard/lenovo/t60/de... PS3, Line 45: device pci 00.0 on # VGA : subsystemid 0x17aa 0x20a4 : end z61t didn't have this
https://review.coreboot.org/c/coreboot/+/34779/3/src/mainboard/lenovo/t60/de... PS3, Line 88: device pci 1c.0 on # Ethernet : subsystemid 0x17aa 0x2001 : end : device pci 1c.1 on end # WLAN : device pci 1c.2 on end # PCIe port 3 : device pci 1c.3 on end # PCIe port 4 : device pci 1c.4 off end # PCIe port 5 : device pci 1c.5 off end # PCIe port 6 I'd move this to the overridetree
https://review.coreboot.org/c/coreboot/+/34779/3/src/mainboard/lenovo/t60/de... PS3, Line 115: subsystemid 0x17aa 0x2012 I'd move this to the overridetree
https://review.coreboot.org/c/coreboot/+/34779/3/src/mainboard/lenovo/t60/de... PS3, Line 191: 4 this irq should be 3, it currently conflicts with 2e.3 (for another patch)
https://review.coreboot.org/c/coreboot/+/34779/3/src/mainboard/lenovo/t60/va... File src/mainboard/lenovo/t60/variants/t60/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/34779/3/src/mainboard/lenovo/t60/va... PS3, Line 20: device pci 00.0 on # Host bridge : subsystemid 0x17aa 0x2015 : end : device pci 01.0 on # PCI-e : device pci 00.0 on # VGA : subsystemid 0x17aa 0x20a4 : end : end already on devicetree
https://review.coreboot.org/c/coreboot/+/34779/3/src/mainboard/lenovo/t60/va... PS3, Line 29: device pci 1c.0 on # Ethernet : subsystemid 0x17aa 0x2001 : end : device pci 1c.1 on end # WLAN : device pci 1c.2 on end # PCIe port 3 : device pci 1c.3 on end # PCIe port 4 : device pci 1e.0 on # PCI Bridge : chip southbridge/ti/pci1x2x : device pci 00.0 on : subsystemid 0x17aa 0x2012 : end : end : end already on devicetree
https://review.coreboot.org/c/coreboot/+/34779/3/src/mainboard/lenovo/t60/va... PS3, Line 47: : chip superio/nsc/pc87384 : device pnp 2e.2 off # Serial Port / IR : irq 0x70 = 4 : end : end already on devicetree