[coreboot-gerrit] Change in coreboot[master]: sc7180: Add display dsi interface programming [Patch 2 of 3]

[Julius Werner (Code Review)]

Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39614 )

Change subject: sc7180: Add display dsi interface programming [Patch 2 of 3]
......................................................................

Patch Set 19:

(1 comment)

https://review.coreboot.org/c/coreboot/+/39614/19/src/soc/qualcomm/sc7180/di... 
File src/soc/qualcomm/sc7180/display/target_sc7180.c:

https://review.coreboot.org/c/coreboot/+/39614/19/src/soc/qualcomm/sc7180/di... 
PS19, Line 75: 	}
I haven't looked closely at this patch yet but you shouldn't have anything like this in SoC code either. This is all completely mainboard-specific! It should all go in mainboard.c. Please see https://review.coreboot.org/cgit/coreboot.git/tree/src/mainboard/google/oak/... for a reference on panel power sequencing.