[coreboot-gerrit] Change in ...coreboot[master]: soc/intel/cannonlake: Add support to log XHCI wake events

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33843 )

Change subject: soc/intel/cannonlake: Add support to log XHCI wake events
......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/#/c/33843/2/src/soc/intel/cannonlake/elog.c 
File src/soc/intel/cannonlake/elog.c:

https://review.coreboot.org/#/c/33843/2/src/soc/intel/cannonlake/elog.c@70 
PS2, Line 70: if (ps->gpe0_sts[GPE_STD] & PME_B0_STS)
            : 		pch_xhci_update_wake_event(&usb_info);
With the current change, you would lose information about PME events other than XHCI. Check skylake pch_log_pme_internal_wake_source to see how this needs to be handled.