Attention is currently required from: Shaunak Saha, Caveh Jalali, Kane Chen, Nick Vaccaro, Patrick Rudolph.
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50870 )
Change subject: soc/intel/tigerlake: Add Acoustic features
......................................................................
Patch Set 2:
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/50870/comment/498a8e26_3e808777
PS2, Line 9: Expose the following FSP UPD interface into coreboot:
: - AcousticNoiseMitigation
: - FastPkgCRampDisable
: - SlowSlewRateFo
Can you please add the details of why this change is being made? (Basically what was identified in CB:50419)
File src/soc/intel/tigerlake/chip.h:
https://review.coreboot.org/c/coreboot/+/50870/comment/5efec723_b4693d0f
PS2, Line 187: VR domain
VCCin VR domain?
https://review.coreboot.org/c/coreboot/+/50870/comment/54ef3a72_8e144e68
PS2, Line 193: FastPkgCRampDisable
Since the UPD is changing, you will have to make the mainboard changes as part of this CL too.
https://review.coreboot.org/c/coreboot/+/50870/comment/a99ba16f_42c9989d
PS2, Line 197: VR domain
VCCin VR domain
--
To view, visit
https://review.coreboot.org/c/coreboot/+/50870
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ica7f1f29995df33bdebb1fd55169cdb36f329ff8
Gerrit-Change-Number: 50870
Gerrit-PatchSet: 2
Gerrit-Owner: Shaunak Saha
shaunak.saha@intel.com
Gerrit-Reviewer: Caveh Jalali
caveh@chromium.org
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Kane Chen
kane.chen@intel.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: Shaunak Saha
shaunak.saha@intel.com
Gerrit-Attention: Caveh Jalali
caveh@chromium.org
Gerrit-Attention: Kane Chen
kane.chen@intel.corp-partner.google.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Thu, 18 Feb 2021 19:32:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment