Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30992 )
Change subject: intel/apollolake: Add IPU to disable_dev function
......................................................................
Patch Set 7:
(1 comment)
https://review.coreboot.org/#/c/30992/7/src/soc/intel/apollolake/chip.c
File src/soc/intel/apollolake/chip.c:
https://review.coreboot.org/#/c/30992/7/src/soc/intel/apollolake/chip.c@485
PS7, Line 485: #if !IS_ENABLED(CONFIG_SOC_INTEL_GLK)
then why you need this check ?
As the commit message tries to explain, the UPD header files of
APL and GLK are incompatible.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/30992
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I75444bf483de32ba641f76ca50e9744fdce2e726
Gerrit-Change-Number: 30992
Gerrit-PatchSet: 7
Gerrit-Owner: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Alex Thiessen
alex.thiessen.de+coreboot@gmail.com
Gerrit-Reviewer: Mario Scheithauer
mario.scheithauer@siemens.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 25 Jan 2019 10:25:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subrata.banik@intel.com
Gerrit-MessageType: comment