Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35110 )
Change subject: soc/mediatek/mt8183: Run DRAM full calibration
......................................................................
Patch Set 50:
(2 comments)
https://review.coreboot.org/c/coreboot/+/35110/47/src/mainboard/google/kukui...
File src/mainboard/google/kukui/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/35110/47/src/mainboard/google/kukui...
PS47, Line 35: DRAM_CBFS := $(CONFIG_CBFS_PREFIX)/dram
That may be a good idea. In the meantime I think we should make it a Kconfig. […]
Let's add the config in another CL.
https://review.coreboot.org/c/coreboot/+/35110/47/src/mainboard/google/kukui...
File src/mainboard/google/kukui/romstage.c:
https://review.coreboot.org/c/coreboot/+/35110/47/src/mainboard/google/kukui...
PS47, Line 44: assert(length <= CALIBRATION_REGION_SIZE);
Can we replace this with Static_assert?
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35110
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8de29b14b1fb24b3b4f351c855c5c4d8f350cc34
Gerrit-Change-Number: 35110
Gerrit-PatchSet: 50
Gerrit-Owner: huayang duan
huayangduan@gmail.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: huayang duan
huayangduan@gmail.com
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Huayang Duan
huayang.duan@mediatek.corp-partner.google.com
Gerrit-CC: Hung-Te Lin
hungte@chromium.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 08 Oct 2019 07:56:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Yu-Ping Wu
yupingso@google.com
Comment-In-Reply-To: Hung-Te Lin
hungte@chromium.org
Gerrit-MessageType: comment