Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40951 )
Change subject: soc/amd/common/block/lpc: Add lpc_disable_spi_rom_sharing
......................................................................
Patch Set 3: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/40951/1/src/soc/amd/common/block/lp...
File src/soc/amd/common/block/lpc/lpc_util.c:
https://review.coreboot.org/c/coreboot/+/40951/1/src/soc/amd/common/block/lp...
PS1, Line 311: pci_write_config8(_LPCB_DEV, LPC_PCI_CONTROL, byte);
It could, though I don't think it's any easier to read. […]
Ack
--
To view, visit
https://review.coreboot.org/c/coreboot/+/40951
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia9ab3803a2f56f68c1164bd241fc3917a3ffcf2b
Gerrit-Change-Number: 40951
Gerrit-PatchSet: 3
Gerrit-Owner: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Mon, 04 May 2020 16:54:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Raul Rangel
rrangel@chromium.org
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-MessageType: comment