Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43067 )
Change subject: Revert "src/amd/common: Exclude biosram from psp_verstage"
......................................................................
Patch Set 5: Code-Review+2
We have garbage collection. I'd rather see you build as much of the common code as possible for ARCH_ARM; otherwise someone will just fork copies of them with minor modifications when need to use them on psp-verstage arises.
point taken
IMHO, when there is no real x86 dependency verstage_x86 should never be used.
i wouldn't make a strict rule out of that, but yes, if it's not really really needed, it should be avoided if possible
--
To view, visit
https://review.coreboot.org/c/coreboot/+/43067
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0a995301404b67224be6addbeebf984c4b5c47d5
Gerrit-Change-Number: 43067
Gerrit-PatchSet: 5
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: 9elements QA
hardwaretestrobot@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 11 Dec 2020 15:43:54 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment