Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48265 )
Change subject: commonlib/bsd/cbfs_mcache: Fix the mcache size in cbmem ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/48265/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/48265/1//COMMIT_MSG@10 PS1, Line 10: is not copied over. Sorry! I guess I did all my overflow testing before the CBMEM jump and never hit this case. This patch isn't the right fix, though: the last tag is actually copied over (you can see this by dumping the cache with cbmem -r 574d5346 | od -t x1 after you booted -- if you can boot, at least).
The bug is that I checked for (end - current > sizeof(tag)) when testing if I overran the buffer, instead of (end - current >= sizeof(tag)). This is the right fix: CB:48277