ron minnich has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37424 )
Change subject: Remove the non-working bayou payload; clean up payloads ......................................................................
Patch Set 2:
(5 comments)
https://review.coreboot.org/c/coreboot/+/37424/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/37424/1//COMMIT_MSG@9 PS1, Line 9: There are coding issues, there are things that don't : build correctly,
a little more detail would be useful (or patches that fix those issues ;)
see payloads/Kconfig, which includes payloads/bayou/Kconfig, which does not exist.
https://review.coreboot.org/c/coreboot/+/37424/1//COMMIT_MSG@18 PS1, Line 18: If a payload is so unloved nobody has looked at it : in years, much less used it, it is time for it to go.
We should drop everything but edk2, seabios, depthcharge and grub2. Possibly drop seabios, too.
I think so. Or start building the builtin payloads as part of autobuild, which we seem not to be doing.
https://review.coreboot.org/c/coreboot/+/37424/1//COMMIT_MSG@21 PS1, Line 21: Bayou was a wonderful idea, and I'm sad to see it go, but ... oh well
I believe Simon Glass reimplemented something like this, too. […]
if we're going to do that, then we need to build them and verify the image too. bayou is just a mess and that may be in part b/c it is not build as part of CI.
https://review.coreboot.org/c/coreboot/+/37424/1/3rdparty/fsp File 3rdparty/fsp:
https://review.coreboot.org/c/coreboot/+/37424/1/3rdparty/fsp@a1 PS1, Line 1: Subproject commit 59964173e18950debcc6b8856c5c928935ce0b4f
This should not be part of this commit.
Done
https://review.coreboot.org/c/coreboot/+/37424/1/MAINTAINERS File MAINTAINERS:
https://review.coreboot.org/c/coreboot/+/37424/1/MAINTAINERS@499 PS1, Line 499: COREINFO PAYLOAD : F: payloads/coreinfo/ : : EXTERNAL PAYLOADS INTEGRATION : M: Stefan Reinauer stefan.reinauer@coreboot.org : M: Martin Roth gaumless@gmail.com : F: payloads/external : : LINUXBOOT PAYLOAD INTEGRATION : M: Philipp Deppenwiese zaolin.daisuki@gmail.com : M: Marcello Sylvester Bauer info@marcellobauer.com : S: Supported : F: payloads/external/LinuxBoot
Do you want to take over these too? Or only libpayload? (Which seems oddly unrelated to the rest of […]
I can take a look at coreinfo and try to resolve build warnings. The other two have maintainers, i.e. you :-) and your stuff all works :-) but let me know what you'd most prefer.