Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30432 )
Change subject: drivers/smmstore: Fix some issues ......................................................................
Patch Set 11:
(3 comments)
https://review.coreboot.org/c/coreboot/+/30432/6/src/drivers/smmstore/store.... File src/drivers/smmstore/store.c:
https://review.coreboot.org/c/coreboot/+/30432/6/src/drivers/smmstore/store.... PS6, Line 187: if (scan_end(&end) == CB_ERR)
No, we don't. cbfs files are not writeable. You can use the incoherent_rdev api, though. […]
Done
https://review.coreboot.org/c/coreboot/+/30432/9/src/drivers/smmstore/store.... File src/drivers/smmstore/store.c:
https://review.coreboot.org/c/coreboot/+/30432/9/src/drivers/smmstore/store.... PS9, Line 200: if (region_is_subregion(region_device_region(&store), &subregion)) {
If you just use rdev_chain() you'll have a region_device that is strictly the are you are about to w […]
Done
https://review.coreboot.org/c/coreboot/+/30432/9/src/drivers/smmstore/store.... PS9, Line 212: key_sz
value_sz
Done