Attention is currently required from: Jamie Ryu, Wonkyu Kim, Ethan Tsao, Ravishankar Sarawadi, John Zhao, Tim Wawrzynczak, Patrick Rudolph.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62013 )
Change subject: soc/inte/common: override PCI dev ids and CPU ids
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
This change is not only for internal development but optimize code.
PCI id tables common code are growing. ex) lpc pci ids in lpc.c are 238.
I don't think this is a valid concern, what we will gain by moving those into SoC layer. in past we had moved this into common to keep SoC code clean and adhere to other SoC/CPU design where PCI IDs stays in common location.
This patch is overriding pci table in common code which is actually used for the silicon.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/62013
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4c2de96389cf35381e910d44ff6e787d3a9661eb
Gerrit-Change-Number: 62013
Gerrit-PatchSet: 2
Gerrit-Owner: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: Ethan Tsao
ethan.tsao@intel.com
Gerrit-Reviewer: Jamie Ryu
jamie.m.ryu@intel.com
Gerrit-Reviewer: John Zhao
john.zhao@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Ravishankar Sarawadi
ravishankar.sarawadi@intel.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Jamie Ryu
jamie.m.ryu@intel.com
Gerrit-Attention: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Attention: Ethan Tsao
ethan.tsao@intel.com
Gerrit-Attention: Ravishankar Sarawadi
ravishankar.sarawadi@intel.com
Gerrit-Attention: John Zhao
john.zhao@intel.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@google.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Wed, 16 Feb 2022 08:33:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Wonkyu Kim
wonkyu.kim@intel.com
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com
Gerrit-MessageType: comment