Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47585 )
Change subject: intel/d945gclf: Disable bootblock console. ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/47585/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/47585/1//COMMIT_MSG@7 PS1, Line 7: d945gclf
Sorry, I just don't have any idea about how this platform works or what is safe to do on it. I can bump C_ENV_BOOTBLOCK_SIZE for that socket to 8K if you want, but I'll have to take your word on it that it's okay to do so. (If this needs any more complicated work than that, I'd prefer to push a patch like this to unblock other patches and leave the cleanup to people who know and can test the platform.)
It's safe for that platform (socket_441, ich7) to increase C_ENV_BOOTBLOCK_SIZE (preferably power of 2 and <= 64K). ATM only intel/d945gclf uses that socket. I have this board but I'm very sure that an increased bootblock size will work fine.