Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32513 )
Change subject: soc/intel/cannonlake: Support different SPD read type for each slot
......................................................................
Patch Set 15: Code-Review+2
(1 comment)
https://review.coreboot.org/#/c/32513/13/src/soc/intel/cannonlake/cnl_memcfg...
File src/soc/intel/cannonlake/cnl_memcfg_init.c:
https://review.coreboot.org/#/c/32513/13/src/soc/intel/cannonlake/cnl_memcfg...
PS13, Line 57: static size_t last_set_spd_data_len;
OK, SGTM.
Static variables should end up in .bss which is initialized to 0. So, by default this will be set to 0.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32513
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I686a85996858204c20fd05ef24787a0487817c34
Gerrit-Change-Number: 32513
Gerrit-PatchSet: 15
Gerrit-Owner: Philip Chen
philipchen@google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Fagerburg
pfagerburg@chromium.org
Gerrit-Reviewer: Philip Chen
philipchen@google.com
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 14 May 2019 00:18:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Paul Fagerburg
pfagerburg@chromium.org
Comment-In-Reply-To: Philip Chen
philipchen@google.com
Gerrit-MessageType: comment