Attention is currently required from: David Wu, Tim Wawrzynczak, Zhuohao Lee. Alan Huang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58105 )
Change subject: mb/google/brya/var/brask: Configurate the GPIOs of LAN ......................................................................
Patch Set 6:
(5 comments)
File src/drivers/net/r8168.c:
PS5:
Changes in this file should be split into a separate change that comes before the mainboard changes […]
Separate to https://review.coreboot.org/c/coreboot/+/59086
File src/mainboard/google/brya/variants/brask/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/58105/comment/d3a71ee9_4824265a PS5, Line 84: 0x05af
This is incorrect. Let's define the led in the buganizer.
Separate to https://review.coreboot.org/c/coreboot/+/59088
https://review.coreboot.org/c/coreboot/+/58105/comment/9344a65d_aa8aa042 PS5, Line 85: register "wake" = "0"
I think you can remove this but let's follow up b/204289108 to see if we need to change the wakeup p […]
Done
https://review.coreboot.org/c/coreboot/+/58105/comment/c2e6b87c_f751d0f1 PS5, Line 86: register "stop_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_H22)"
IIUC, this setting will disable the wake on lan. […]
From 8125 spec., this pin will not disable wake-on-lan. We will double check it.
https://review.coreboot.org/c/coreboot/+/58105/comment/a250fef6_4c4c8878 PS5, Line 90: register "device_index" = "0"
not required, the default value is already `0`
Done