Jakub Czapiga has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48557 )
Change subject: tests: Add lib/fmap-test test case
......................................................................
Patch Set 7:
(1 comment)
File tests/lib/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/48557/comment/13e6115c_7b442a64
PS7, Line 53: fmap-test-cflags += -I tests/include/tests/lib/fmap
Does this do anything? fmap-test.c includes these by full path (as I think it should).
Yes, it does. If you open src/lib/fmap.c and look at includes, then you will see:
#include "fmap_config.h"
This path has to be in the compiler include paths for correct compilation.
Includes in the test source file are using full test include paths to indicate, that those are not part of the original coreboot source.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/48557
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I885ea05d509d3b1330de7a18531f310d290c6965
Gerrit-Change-Number: 48557
Gerrit-PatchSet: 7
Gerrit-Owner: Jakub Czapiga
jacz@semihalf.com
Gerrit-Reviewer: Jan Dabros
jsd@semihalf.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Paul Fagerburg
pfagerburg@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: 9elements QA
hardwaretestrobot@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Comment-Date: Tue, 17 Aug 2021 07:40:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Gerrit-MessageType: comment