Attention is currently required from: Subrata Banik, Tim Wawrzynczak, Angel Pons, Patrick Rudolph, EricR Lai.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60536 )
Change subject: soc/intel/alderlake: Add provision to enable SoC debug interface
......................................................................
Patch Set 2:
(2 comments)
Patchset:
PS2:
I'm a bit confused by this. It seems only useful if one wants to debug
raminit. "The top level switch" sounds like something one would want
always enabled for debugging, OTOH. If it's just what you need right
now for convenience, you could also add something to site-local/?
File src/soc/intel/alderlake/Kconfig:
https://review.coreboot.org/c/coreboot/+/60536/comment/319a3f60_b20c4b32
PS2, Line 114: The top level switch to enable soc debug interface
This should give a hint about what it does, e.g. very verbose debug
output.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/60536
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I259c8069414de5b045a59279a3e4a62bc392588f
Gerrit-Change-Number: 60536
Gerrit-PatchSet: 2
Gerrit-Owner: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Attention: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Comment-Date: Sat, 01 Jan 2022 20:05:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment