Meera Ravindranath has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38682 )
Change subject: src/soc/tigerlake: Define and use config for number of USB2/3 ports ......................................................................
Patch Set 5:
(5 comments)
Patch Set 1:
(3 comments)
https://review.coreboot.org/c/coreboot/+/38682/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/38682/1//COMMIT_MSG@7 PS1, Line 7: .
Define and use config for number of USB2/3 ports
Done
https://review.coreboot.org/c/coreboot/+/38682/1//COMMIT_MSG@7 PS1, Line 7: rc/soc/tigerlake: Define and use a Kconfig for no of USB ports.
Can we add a small description.
Done
https://review.coreboot.org/c/coreboot/+/38682/4//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/38682/4//COMMIT_MSG@7 PS4, Line 7: .
not needed.
Done
https://review.coreboot.org/c/coreboot/+/38682/1/src/soc/intel/tigerlake/Kco... File src/soc/intel/tigerlake/Kconfig:
https://review.coreboot.org/c/coreboot/+/38682/1/src/soc/intel/tigerlake/Kco... PS1, Line 159: DEV
port
Done
https://review.coreboot.org/c/coreboot/+/38682/4/src/soc/intel/tigerlake/fsp... File src/soc/intel/tigerlake/fsp_params_jsl.c:
https://review.coreboot.org/c/coreboot/+/38682/4/src/soc/intel/tigerlake/fsp... PS4, Line 111: usb2_ports[i]
the chip.h also needs to be updated to have array size defined as per config.
Done