Paul Fagerburg has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32475 )
Change subject: soc/intel/cannonlake: Modify dq_map to provide for 6 entries
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/#/c/32475/2/src/soc/intel/cannonlake/include/soc...
File src/soc/intel/cannonlake/include/soc/cnl_memcfg_init.h:
https://review.coreboot.org/#/c/32475/2/src/soc/intel/cannonlake/include/soc...
PS2, Line 76: * above.
It would be good to remove the dqs_map setting in hatch since it is unused anyways.
I uploaded a new CL for hatch baseboard and added you as reviewer.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32475
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I20a768de0e4440d7dde7b717794c4e2d0c62819c
Gerrit-Change-Number: 32475
Gerrit-PatchSet: 2
Gerrit-Owner: Paul Fagerburg
pfagerburg@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Fagerburg
pfagerburg@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 26 Apr 2019 21:23:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment