[coreboot-gerrit] Change in coreboot[master]: soc/intel/block/pmclib.c: Properly guard apm_control()

[Patrick Georgi (Code Review)]

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/47757 )

Change subject: soc/intel/block/pmclib.c: Properly guard apm_control()
......................................................................

soc/intel/block/pmclib.c: Properly guard apm_control()

This function is only properly implemented with SMM support.

Change-Id: I9e0fc7433a9226825f5ae4903c0ff2e0162d86ac
Signed-off-by: Arthur Heymans 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/47757
Tested-by: build bot (Jenkins) 
Reviewed-by: Angel Pons 
---
M src/soc/intel/common/block/pmc/pmclib.c
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  build bot (Jenkins): Verified
  Angel Pons: Looks good to me, approved

diff --git a/src/soc/intel/common/block/pmc/pmclib.c b/src/soc/intel/common/block/pmc/pmclib.c
index 02ca6de..09af749 100644
--- a/src/soc/intel/common/block/pmc/pmclib.c
+++ b/src/soc/intel/common/block/pmc/pmclib.c
@@ -713,7 +713,7 @@

void pmc_set_acpi_mode(void)
 {
-	if (!acpi_is_wakeup_s3()) {
+	if (!CONFIG(NO_SMM) && !acpi_is_wakeup_s3()) {
    	apm_control(APM_CNT_ACPI_DISABLE);
    }
 }