Attention is currently required from: Cliff Huang, Intel coreboot Reviewers, Jérémy Compostella, Matt DeVillier, Nick Vaccaro, Paul Menzel, Subrata Banik.
Sean Rhodes has posted comments on this change by Sean Rhodes. ( https://review.coreboot.org/c/coreboot/+/86403?usp=email )
Change subject: soc/intel/common: Add support for RTD3 on CNVi
......................................................................
Patch Set 27:
(1 comment)
Patchset:
PS20:
might not be necessary, since everything is conditional (CondRefOf) on the control method, and that […]
I'd agree with Matt, as it's just a single line in devicetree but if you're just suggesting checking against Kconfig, there's no harm?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/86403?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I22292ad97c439e50fe5d7a6b79f77847e71ca62c
Gerrit-Change-Number: 86403
Gerrit-PatchSet: 27
Gerrit-Owner: Sean Rhodes
sean@starlabs.systems
Gerrit-Reviewer: Cliff Huang
cliff.huang@intel.com
Gerrit-Reviewer: Intel coreboot Reviewers
intel_coreboot_reviewers@intel.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Sean Rhodes
sean@starlabs.systems
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-CC: Matt DeVillier
matt.devillier@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Cliff Huang
cliff.huang@intel.com
Gerrit-Attention: Intel coreboot Reviewers
intel_coreboot_reviewers@intel.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Attention: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Comment-Date: Wed, 19 Feb 2025 19:52:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com
Comment-In-Reply-To: Matt DeVillier
matt.devillier@gmail.com