Attention is currently required from: Daniel Peng, Karthik Ramasubramanian, Nick Vaccaro.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78310?usp=email )
Change subject: mb/google/brya/var/marasov: Enable wifi sar table for Intel module ......................................................................
Patch Set 3:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/78310/comment/d5f61a2a_6b355e21 : PS3, Line 2: Daniel_Peng Please update your git configuration to remove the underscore in the name:
$ git config --global user.name "Daniel Peng" $ git commit -s --amend --author="Daniel Peng Daniel_Peng@pegatron.corp-partner.google.com"
File src/mainboard/google/brya/variants/marasov/variant.c:
https://review.coreboot.org/c/coreboot/+/78310/comment/564388d9_d969f420 : PS3, Line 13: printk(BIOS_INFO, "Use wifi_sar_1.hex.\n"); Info messages should be understandable to “normal” users. Could you please rephrase it?
https://review.coreboot.org/c/coreboot/+/78310/comment/7ca7a320_92138d44 : PS3, Line 17: printk(BIOS_INFO, "Intel Wi-Fi SAR not used, return NULL!\n"); It’d be great, if you rephrased this too.