[coreboot-gerrit] Change in coreboot[master]: intel/fsp2_0: Add soc_validate_fsp_version for FSP version check

[Marc Jones (Code Review)]

Marc Jones has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47559 )

Change subject: intel/fsp2_0: Add soc_validate_fsp_version for FSP version check
......................................................................

Patch Set 1:

(1 comment)

This part looks ok. The scheme for this fsp version should be described in to follow-on patch that implements the check.

https://review.coreboot.org/c/coreboot/+/47559/1/src/drivers/intel/fsp2_0/ut... 
File src/drivers/intel/fsp2_0/util.c:

https://review.coreboot.org/c/coreboot/+/47559/1/src/drivers/intel/fsp2_0/ut... 
PS1, Line 250: __weak void soc_validate_fsp_version(const struct fsp_header *hdr) { }
Maybe print a DEBUG __func__ not implemented on this weak call. We should encourage version checks.