Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41757 )
Change subject: drivers/vpd: Fix VPD speed regressions on non-x86 devices
......................................................................
Patch Set 5: Code-Review+2
this looks good to me, but will that work on x86 bootblock/romstage since you've used static?
This restriction has been eliminated (at least for static data initialized to zero). See CB:40535.
Good to know it's fixed. That was why we implemented the vpd in such way last time.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/41757
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I55a103180b290c1563e35a25496188b6a82e49ff
Gerrit-Change-Number: 41757
Gerrit-PatchSet: 5
Gerrit-Owner: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 28 May 2020 00:37:12 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment