Attention is currently required from: Michał Żygowski, Christian Walter, Julius Werner, Krystian Hebel.
Sergii Dmytruk has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68989 )
Change subject: security/tpm: remove tis_close()
......................................................................
Patch Set 2:
(2 comments)
File src/drivers/pc80/tpm/tis.c:
https://review.coreboot.org/c/coreboot/+/68989/comment/4cacb8c0_674eeab3
PS1, Line 664: if (tis_close())
I think rather than doing the whole "drop access, re-request access" thing, a simpler way to write t […]
Done
https://review.coreboot.org/c/coreboot/+/68989/comment/14a914d4_c8d33317
PS1, Line 742: if (!has_access && tis_close() < 0)
Oh, I completely missed that it's used down here too. […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/68989
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9df76adfc21fca9fa1d1af7c40635ec0684ceb0f
Gerrit-Change-Number: 68989
Gerrit-PatchSet: 2
Gerrit-Owner: Sergii Dmytruk
sergii.dmytruk@3mdeb.com
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Krystian Hebel
krystian.hebel@3mdeb.com
Gerrit-Reviewer: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Attention: Christian Walter
christian.walter@9elements.com
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Attention: Krystian Hebel
krystian.hebel@3mdeb.com
Gerrit-Comment-Date: Sat, 12 Nov 2022 22:50:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Gerrit-MessageType: comment