Nico Huber has submitted this change and it was merged. ( https://review.coreboot.org/21207 )
Change subject: gma: Fix refined contract of Initialize() ......................................................................
gma: Fix refined contract of Initialize()
To be compatible with HW.PCI.Dev implementations that do actual register accesses, we have to account for hardware state updates.
Change-Id: I86e42163d7847f7011bcf9a0ef5c2c7f25b4b1be Signed-off-by: Nico Huber nico.h@gmx.de Reviewed-on: https://review.coreboot.org/21207 Reviewed-by: Patrick Georgi pgeorgi@google.com Reviewed-by: Adrian-Ken Rueegsegger ken@codelabs.ch --- M common/hw-gfx-gma.adb 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: Nico Huber: Verified Patrick Georgi: Looks good to me, approved Adrian-Ken Rueegsegger: Looks good to me, but someone else must approve
diff --git a/common/hw-gfx-gma.adb b/common/hw-gfx-gma.adb index 94f3ceb..101de18 100644 --- a/common/hw-gfx-gma.adb +++ b/common/hw-gfx-gma.adb @@ -301,7 +301,7 @@ with Refined_Global => (In_Out => - (Config.Valid_Port_GPU, + (Config.Valid_Port_GPU, Dev.PCI_State, Registers.Register_State, Port_IO.State), Input => (Time.State),