Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38926 )
Change subject: Documentation: Add GM45 ThinkPads common page ......................................................................
Patch Set 4:
(3 comments)
https://review.coreboot.org/c/coreboot/+/38926/4/Documentation/mainboard/ind... File Documentation/mainboard/index.md:
https://review.coreboot.org/c/coreboot/+/38926/4/Documentation/mainboard/ind... PS4, Line 80: xx00_series.md Please don't use this naming scheme. I introduced it, but it's too confusing. I'll send a patch series to clean that.
Please name it intel_gm45_series.md or similar.
https://review.coreboot.org/c/coreboot/+/38926/4/Documentation/mainboard/len... File Documentation/mainboard/lenovo/xx00_series.md:
https://review.coreboot.org/c/coreboot/+/38926/4/Documentation/mainboard/len... PS4, Line 1: T400 This tutorial only works on x200
https://review.coreboot.org/c/coreboot/+/38926/4/Documentation/mainboard/len... PS4, Line 27: `util/bincfg` Why don't you use ifdtool? That would work for all GM45 models.