Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33004 )
Change subject: nb/intel/nehalem/raminit.c: Remove variable set but not used
......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/#/c/33004/5/src/northbridge/intel/nehalem/ramini...
File src/northbridge/intel/nehalem/raminit.c:
https://review.coreboot.org/#/c/33004/5/src/northbridge/intel/nehalem/ramini...
PS5, Line 2256:
I suppose this line is removed due to line 2275, but is 2275 always executed?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/33004
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5d3a04970fa57f07ca7dd748f114ac0cd6955522
Gerrit-Change-Number: 33004
Gerrit-PatchSet: 5
Gerrit-Owner: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Patrick Georgi
pgeorgi@google.com
Gerrit-Comment-Date: Mon, 03 Jun 2019 13:31:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment