Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34123 )
Change subject: mb/lenovo/{t60,z61t}: Convert to variant board ......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/34123/2/src/mainboard/lenovo/t60/Kc... File src/mainboard/lenovo/t60/Kconfig:
https://review.coreboot.org/c/coreboot/+/34123/2/src/mainboard/lenovo/t60/Kc... PS2, Line 1: confi I wouldn't use a "baseboard" Kconfig symbol here, since there's no "baseboard" (just two boards with common code). I would just use the original if, with an or:
if BOARD_LENOVO_T60 || BOARD_LENOVO_Z61T
https://review.coreboot.org/c/coreboot/+/34123/2/src/mainboard/lenovo/t60/Kc... PS2, Line 36: config DEVICETREE There's no need to override this. A common devicetree and a variant-specific overridetree should be used instead anyway.