Hung-Te Lin has submitted this change. ( https://review.coreboot.org/c/coreboot/+/48352 )
Change subject: device/azalia_device.c: Clarify comment ......................................................................
device/azalia_device.c: Clarify comment
The `4` here doesn't have to do with the size of u32. Instead, it is because the verb header contains the number of jacks, which is the number of four-verb groups.
Change-Id: I3956ce5ec2a7abc29982504cf75b262a1c098af5 Signed-off-by: Angel Pons th3fanbus@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/48352 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Patrick Rudolph siro@das-labor.org --- M src/device/azalia_device.c 1 file changed, 2 insertions(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Patrick Rudolph: Looks good to me, approved
diff --git a/src/device/azalia_device.c b/src/device/azalia_device.c index e46c27f..ab370f9 100644 --- a/src/device/azalia_device.c +++ b/src/device/azalia_device.c @@ -115,7 +115,8 @@ int idx = 0;
while (idx < (verb_table_bytes / sizeof(u32))) { - u32 verb_size = 4 * verb_table[idx + 2]; // in u32 + /* Header contains the number of jacks, aka groups of 4 dwords */ + u32 verb_size = 4 * verb_table[idx + 2]; if (verb_table[idx] != viddid) { idx += verb_size + 3; // skip verb + header continue;