Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42888 )
Change subject: soc/amd/picasso: Enable paging on S3 resume
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42888/2/src/soc/amd/picasso/page_ma...
File src/soc/amd/picasso/page_map_s3.txt:
https://review.coreboot.org/c/coreboot/+/42888/2/src/soc/amd/picasso/page_ma...
PS2, Line 3: 0xcbd0b000, 0xd0000000, WB, # RAM for CBMEM and FSP
: 0x100000, 0x2BD000, WB, # RAM for lower memory usage
I think ideally these would be runtime mapped.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/42888
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I58fed6f297831b3cdc2758a5e7610388171d84d3
Gerrit-Change-Number: 42888
Gerrit-PatchSet: 2
Gerrit-Owner: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph.100@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Mon, 29 Jun 2020 21:57:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment