HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45270 )
Change subject: xeon_sp: Update skx pci_irq.asl for ACPI2.0 notation ......................................................................
Patch Set 1:
(4 comments)
https://review.coreboot.org/c/coreboot/+/45270/1/src/soc/intel/xeon_sp/skx/a... File src/soc/intel/xeon_sp/skx/acpi/pci_irq.asl:
https://review.coreboot.org/c/coreboot/+/45270/1/src/soc/intel/xeon_sp/skx/a... PS1, Line 61: Store oops, this one also :)
https://review.coreboot.org/c/coreboot/+/45270/1/src/soc/intel/xeon_sp/skx/a... PS1, Line 64: ShiftLeft same
https://review.coreboot.org/c/coreboot/+/45270/1/src/soc/intel/xeon_sp/skx/a... PS1, Line 71: Decrement (Local0) \ : Store also this
https://review.coreboot.org/c/coreboot/+/45270/1/src/soc/intel/xeon_sp/skx/a... PS1, Line 76: And old acpi