Nico Huber has submitted this change and it was merged. ( https://review.coreboot.org/26833 )
Change subject: g45/hw-gfx-gma-gmch-hdmi.adb: Use GMCH_HDMI_MODE_SELECT_DVI ......................................................................
g45/hw-gfx-gma-gmch-hdmi.adb: Use GMCH_HDMI_MODE_SELECT_DVI
With GMCH_HDMI_MODE_SELECT_HDMI set the controller will be sending null packets during Vsync. This only works on displays supporting HDMI operation, while GMCH_HDMI_MODE_SELECT_DVI ought to work on all HDMI/DVI displays.
Change-Id: I75c669b913ef4d5494d78bed55f8e38bba0b0362 Signed-off-by: Arthur Heymans arthur@aheymans.xyz Reviewed-on: https://review.coreboot.org/26833 Reviewed-by: Nico Huber nico.h@gmx.de --- M common/g45/hw-gfx-gma-gmch-hdmi.adb 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: Arthur Heymans: Verified Nico Huber: Looks good to me, approved
diff --git a/common/g45/hw-gfx-gma-gmch-hdmi.adb b/common/g45/hw-gfx-gma-gmch-hdmi.adb index 4c84f36..3e34c52 100644 --- a/common/g45/hw-gfx-gma-gmch-hdmi.adb +++ b/common/g45/hw-gfx-gma-gmch-hdmi.adb @@ -66,7 +66,7 @@ Mask_Set => GMCH_HDMI_ENABLE or GMCH_PORT_PIPE_SELECT (Pipe) or GMCH_HDMI_SDVO_ENCODING_HDMI or - GMCH_HDMI_MODE_SELECT_HDMI or + GMCH_HDMI_MODE_SELECT_DVI or Polarity); end On;