Attention is currently required from: Paul Menzel, Alex James. Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60219 )
Change subject: commonlib: Add endian definitions for macOS ......................................................................
Patch Set 2:
(2 comments)
Patchset:
PS2:
I could define these as preprocessor macros if that would be preferred.
If that works, yeah, I think that would be nice just to keep the visual space taken up by this a bit smaller. (Alternatively, if this gets too big you could add a separate sysincludes_macos.h here where you put all that stuff in which you then chain-include for defined(__APPLE__).)
PS2: I'm surprised that MacOS doesn't have these... I don't have a MacBook at hand right now, but I found some suggestions online that there's a <machine/endian.h> which has these. Can you try to see if that works? Would be a little easier.