Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38743 )
Change subject: nb/intel/haswell/peg: Add PEG driver stub ......................................................................
Patch Set 5:
Uhm, folks, why did such a simple naming issue escalate like this?
Some general statements about that:
- It's sometimes useful to do what other platforms with the same chipset do so drivers are happier.
- We can still change object names later once we see that it improves matters in some way.
- I understood Angel's remarks to be suggestions with some reasoning (even if badly phrased). Pointing out that you want to keep the names is okay. Explaining why is even better.
- That passive-aggressive "No." isn't helpful. Neither are "Yes" or "Whatever". As such, I'd be careful about assigning "destructive behavior" to any single participant in this exchange. Cut it down and let's go back to the code, okay?