Attention is currently required from: Patrick Rudolph, Lee Leahy. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63205 )
Change subject: drivers/intel/fsp1_1/hob.c: Don't use broken FSP macros ......................................................................
Patch Set 1:
(5 comments)
File src/drivers/intel/fsp1_1/hob.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-145029): https://review.coreboot.org/c/coreboot/+/63205/comment/0647f446_958f1e94 PS1, Line 32: /* TODO: It looks like we violate the const qualifier a lot so use an union to work 'an union' may be misspelled - perhaps 'a union'?
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-145029): https://review.coreboot.org/c/coreboot/+/63205/comment/ee43f837_2a3692b3 PS1, Line 42: union efi_hob hob = { .header = parent } ; space prohibited before semicolon
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-145029): https://review.coreboot.org/c/coreboot/+/63205/comment/32e26f50_2405deef PS1, Line 59: union efi_hob hob = { .header = hob_start }; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-145029): https://review.coreboot.org/c/coreboot/+/63205/comment/c0e01211_3bab7d28 PS1, Line 59: union efi_hob hob = { .header = hob_start }; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-145029): https://review.coreboot.org/c/coreboot/+/63205/comment/b7292802_39d206d7 PS1, Line 244: void *hob = NULL;; Statements terminations use 1 semicolon