Attention is currently required from: Felix Singer.
Jonathon Hall has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80055?usp=email )
Change subject: mb/purism/librem_l1um_v2: Use chipset dt reference names
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
File src/mainboard/purism/librem_l1um_v2/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/80055/comment/6198a8cd_fa942ca5 :
PS1, Line 44: device pci 01.0 on # PCIE6 - x16 or x8
I thought they might be superfluous since the smbios lines say the same. […]
Ah, on second thought I'm fine with that then. Should have read a few more lines down. No need to write the same thing twice.
Thanks!
--
To view, visit
https://review.coreboot.org/c/coreboot/+/80055?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Id592241a1dc33559115800da10a57a5fc10867f9
Gerrit-Change-Number: 80055
Gerrit-PatchSet: 1
Gerrit-Owner: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Reviewer: Jonathon Hall
jonathon.hall@puri.sm
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Comment-Date: Thu, 18 Jan 2024 19:02:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Felix Singer
service+coreboot-gerrit@felixsinger.de
Comment-In-Reply-To: Jonathon Hall
jonathon.hall@puri.sm
Gerrit-MessageType: comment