Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45773 )
Change subject: [RFC] vpd: Add vpd_get_int() function
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45773/3/src/drivers/vpd/vpd.c
File src/drivers/vpd/vpd.c:
https://review.coreboot.org/c/coreboot/+/45773/3/src/drivers/vpd/vpd.c@290
PS3, Line 290: if (!vpd_gets(key, value, sizeof(value), region))
Isn't this easier/cleaner if you build it on top of vpd_find() (like vpd_get_bool())?
Are VPDs guaranteed to be 0-terminated?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45773
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1c1b5710a5236fe4a3bdda1fc978393e636e9817
Gerrit-Change-Number: 45773
Gerrit-PatchSet: 3
Gerrit-Owner: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Marc Jones
marc.jones@amd.corp-partner.google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: insomniac
insomniac@slackware.it
Gerrit-CC: Felix Singer
felixsinger@posteo.net
Gerrit-CC: Julius Werner
jwerner@chromium.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 08 Oct 2020 19:13:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Gerrit-MessageType: comment