Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47899 )
Change subject: mb/google/hatch: Drop use of SPD cache for puff-based variants
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/47899/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/47899/1//COMMIT_MSG@19
PS1, Line 19: Test: build/boot WYVERN variant, check boot times via cbmem:
: w/SPD caching: ~722 ms
: w/FSP reading: ~627 ms
Hi Matt, Do you see the different between cold reboot and warm reboot? […]
and on a Librem 14 (CML) development unit (w/2 sodimms):
with SPD cache
cold: 634,xxx (occasionally 734,xxx)
warm: 643,xxx
without SPD cache
cold: 639,xxx
warm: 637,xxx
<shrugs>
maybe I'll just continue my patch to add the SPD cache as an option for the default FMAP
--
To view, visit
https://review.coreboot.org/c/coreboot/+/47899
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4e4db9ba9fdb0fa9fafb2645819b111d381b5756
Gerrit-Change-Number: 47899
Gerrit-PatchSet: 1
Gerrit-Owner: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Jamie Chen
jamie.chen@intel.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Jamie Chen
jamie.chen@intel.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Comment-Date: Tue, 01 Dec 2020 04:45:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Jamie Chen
jamie.chen@intel.corp-partner.google.com
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Comment-In-Reply-To: Matt DeVillier
matt.devillier@gmail.com
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-MessageType: comment