[coreboot-gerrit] [S] Change in coreboot[main]: mb/google/brya: Do not select HAVE_ACPI_RESUME

[Paul Menzel (Code Review)]

Attention is currently required from: Dinesh Gehlot, Jayvik Desai, Kapil Porwal, Nick Vaccaro.

Paul Menzel has posted comments on this change by Dinesh Gehlot. ( https://review.coreboot.org/c/coreboot/+/86422?usp=email )

The change is no longer submittable: All-Comments-Resolved is unsatisfied now.

Change subject: mb/google/brya: Do not select HAVE_ACPI_RESUME
......................................................................

Patch Set 2:

(2 comments)

Commit Message:

https://review.coreboot.org/c/coreboot/+/86422/comment/43ee0c64_33eed786?usp... :
PS1, Line 9: Brya mainboard does not reliably support S3 entry/exit.
> Its a configuration, system will not suspend to S3 but s0ix, enabling quicker resume. […]

Please update the commit message then. It says, ACPI S3 could work.

Is it a hardware or software (firmware) limitation.

https://review.coreboot.org/c/coreboot/+/86422/comment/4f375b84_8dfe4660?usp... :
PS1, Line 10: Also trigger a fail-safe board
            : reset if the system resumes from S3.
> These changes are designed to work in conjunction and are best submitted as a single commit. […]

Sorry for not being clear in my comment. How can Chromebook with ChromeOS go into ACPI S3 if it’s not advertised by firmware?