Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40520 )
Change subject: drivers/smmstore: Implement SMMSTORE version 2 ......................................................................
Patch Set 14:
(4 comments)
https://review.coreboot.org/c/coreboot/+/40520/7/src/drivers/smmstore/ramsta... File src/drivers/smmstore/ramstage.c:
https://review.coreboot.org/c/coreboot/+/40520/7/src/drivers/smmstore/ramsta... PS7, Line 73: BS_DEV_INIT
ah, I was testing on an AMD Stoneyridge Chromebook (same one having PCI init issues w/Tiano), and th […]
This should be fixed in latest revision
https://review.coreboot.org/c/coreboot/+/40520/1/src/drivers/smmstore/smi.c File src/drivers/smmstore/smi.c:
https://review.coreboot.org/c/coreboot/+/40520/1/src/drivers/smmstore/smi.c@... PS1, Line 63: case SMMSTORE_CMD_INFO: {
Added a Kconfig as the V1 API allows to write to arbitrary locations in DRAM, while V2 only allows t […]
Added Kconfig option
https://review.coreboot.org/c/coreboot/+/40520/6/src/drivers/smmstore/smi.c File src/drivers/smmstore/smi.c:
https://review.coreboot.org/c/coreboot/+/40520/6/src/drivers/smmstore/smi.c@... PS6, Line 154: if (!CONFIG(SMMSTOREV2)) : return smmstorev1_exec(command, param); : else : return smmstorev2_exec(command, param);
It should probably be mentioned in the commit message and the documentation they are mutually exclus […]
done
https://review.coreboot.org/c/coreboot/+/40520/7/src/drivers/smmstore/store.... File src/drivers/smmstore/store.c:
https://review.coreboot.org/c/coreboot/+/40520/7/src/drivers/smmstore/store.... PS7, Line 315: printk(BIOS_ERR, "smm store: lookup of com buffer failed\n");
issue is with AMD Stoney not having SMM until after romstage, and thus not having a buffer
That should be fixed in latest version