Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34285 )
Change subject: soc/intel: Fix regression with hidden PCI devices ......................................................................
Patch Set 3:
(1 comment)
Patch Set 3:
Patch Set 2:
Not tested, Maxim ?
Thanks for this patch. Now it works well I can see such devices in the console:
$ grep -rn "BUG:" 34285-console.log
34:BUG: soc_peg_init_params requests hidden 00:01.1 35:BUG: soc_peg_init_params requests hidden 00:01.2 1132:BUG: me_read_config32 requests hidden 00:16.0 1370:BUG: pch_log_rp_wake_source requests hidden 00:1c.1 1371:BUG: pch_log_rp_wake_source requests hidden 00:1c.2 1372:BUG: pch_log_rp_wake_source requests hidden 00:1c.3 1373:BUG: pch_log_rp_wake_source requests hidden 00:1c.4 1374:BUG: pch_log_rp_wake_source requests hidden 00:1c.7 1375:BUG: pch_log_rp_wake_source requests hidden 00:1d.0 1376:BUG: pch_log_rp_wake_source requests hidden 00:1d.1 1377:BUG: pch_log_rp_wake_source requests hidden 00:1d.2 1378:BUG: pch_log_rp_wake_source requests hidden 00:1d.3 1638:BUG: me_read_config32 requests hidden 00:16.0 1639:BUG: me_read_config32 requests hidden 00:16.0 1640:BUG: me_read_config32 requests hidden 00:16.0 1641:BUG: me_read_config32 requests hidden 00:16.0 1645:BUG: me_read_config32 requests hidden 00:16.0 1647:BUG: me_read_config32 requests hidden 00:16.0 1675:BUG: p2sb_get_device requests hidden 00:1f.1 1676:BUG: p2sb_get_device requests hidden 00:1f.1 1677:BUG: p2sb_get_device requests hidden 00:1f.1 1678:BUG: p2sb_get_device requests hidden 00:1f.1 1679:BUG: p2sb_get_device requests hidden 00:1f.1 1680:BUG: p2sb_get_device requests hidden 00:1f.1 1681:BUG: p2sb_get_device requests hidden 00:1f.1 1682:BUG: p2sb_get_device requests hidden 00:1f.1 1683:BUG: p2sb_get_device requests hidden 00:1f.1 1684:BUG: p2sb_get_device requests hidden 00:1f.1 1685:BUG: p2sb_get_device requests hidden 00:1f.1 1686:BUG: p2sb_get_device requests hidden 00:1f.1 1687:BUG: p2sb_get_device requests hidden 00:1f.1 1688:BUG: p2sb_get_device requests hidden 00:1f.1 1689:BUG: p2sb_get_device requests hidden 00:1f.1 1690:BUG: p2sb_get_device requests hidden 00:1f.1 1691:BUG: p2sb_get_device requests hidden 00:1f.1 1692:BUG: p2sb_get_device requests hidden 00:1f.1 1693:BUG: p2sb_get_device requests hidden 00:1f.1 1694:BUG: p2sb_get_device requests hidden 00:1f.1 1695:BUG: p2sb_get_device requests hidden 00:1f.1 1696:BUG: p2sb_get_device requests hidden 00:1f.1 1697:BUG: p2sb_get_device requests hidden 00:1f.1 1698:BUG: p2sb_get_device requests hidden 00:1f.1
https://review.coreboot.org/c/coreboot/+/34285/3/src/device/device_const.c File src/device/device_const.c:
https://review.coreboot.org/c/coreboot/+/34285/3/src/device/device_const.c@2... PS3, Line 243: BUG: %s requests hidden 00:%02x.%d\ Not everything that is reported will truly be a bug. In the output pasted by Maxim, following calls are fine since they check against !dev:
soc_peg_init_params pch_log_rp_wake_source
On the other hand this is a true bug: me_read_config32. It does not check for NULL. But I think that would be a common problem. I see a lot of uses of PCH_DEV_* macro being passed as an argument to some function without any check.
On the other hand, this is another problem: p2sb_get_device. Here the device seems to be hidden and the functions seem to be un-hiding it. If you plan to get rid of dev_find_slot() completely, what is your plan on supporting such devices?