Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32664 )
Change subject: vboot: remove use of VbInitParams
......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/#/c/32664/5/src/security/vboot/vboot_common.h
File src/security/vboot/vboot_common.h:
https://review.coreboot.org/#/c/32664/5/src/security/vboot/vboot_common.h@42
PS5, Line 42: uint32_t out_flags;
I'd suggest adding a u32 reserved above here, so that the layout of the struct stays the same. Eventually we'll wanna remove this entirely, but until then it would be nice to keep the interface stable (where it's not too much of a hassle, at least).
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32664
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibe02cb6ba639de0d7cbdf79fc4dbf49044c92278
Gerrit-Change-Number: 32664
Gerrit-PatchSet: 5
Gerrit-Owner: Joel Kitching
kitching@google.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Joel Kitching
kitching@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Julius Werner
jwerner@chromium.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 07 May 2019 21:36:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment