Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48862 )
Change subject: drivers/intel/gma: Rework brightness level includes ......................................................................
Patch Set 1:
Patch Set 1:
I'm somehow missing, what the improvement here really is besides that the custom brightness table version is more explicit and more flexible.
the improvement is that this allows gma.asl to be included to provide the GFX0 device without forcing the inclusion of unnecessary brightness controls for devices without an internal panel.
the use case driving this change is running MacOS on Chromeboxes where the GFX0 device is required
So, for the case with default brightness nothing changes, right?
correct.
I'm certainly open to alternative implementations to achieve the same decoupling