build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32854 )
Change subject: util/romcc: Use 64 bit integers when shifting
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/#/c/32854/2/util/romcc/romcc.c
File util/romcc/romcc.c:
https://review.coreboot.org/#/c/32854/2/util/romcc/romcc.c@14220
PS2, Line 14220: if (used_indices & ((uint64_t)1 << index)) {
braces {} are not necessary for single statement blocks
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32854
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibd089df6be60c8ea46da11e5e83cd58b2e2c54d6
Gerrit-Change-Number: 32854
Gerrit-PatchSet: 2
Gerrit-Owner: Jacob Garber
jgarber1@ualberta.ca
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Jacob Garber
jgarber1@ualberta.ca
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Mon, 20 May 2019 16:23:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment