[coreboot-gerrit] Change in coreboot[master]: acpi: Be more ACPI compliant when generating _UID

[Patrick Rudolph (Code Review)]

Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37695 )

Change subject: acpi: Be more ACPI compliant when generating _UID
......................................................................

Patch Set 5:

(4 comments)

https://review.coreboot.org/c/coreboot/+/37695/4//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/37695/4//COMMIT_MSG@9 
PS4, Line 9: * Add a CRC32 generator
> Maybe split this out into a separate patch?

done in CB:37753

https://review.coreboot.org/c/coreboot/+/37695/4/src/include/crc_byte.h 
File src/include/crc_byte.h:

https://review.coreboot.org/c/coreboot/+/37695/4/src/include/crc_byte.h@40 
PS4, Line 40:  * 0x04c11db7.
> Please use the same notation as the other functions above.

done in CB:37753

https://review.coreboot.org/c/coreboot/+/37695/4/src/include/crc_byte.h@47 
PS4, Line 47: uint32_t crc32_byte(const uint8_t *buf, size_t len, const uint32_t init);
> While I agree that the function signatures should be consistent, I would rather not see that macro i […]

done in CB:37753

https://review.coreboot.org/c/coreboot/+/37695/4/src/lib/crc_byte.c 
File src/lib/crc_byte.c:

https://review.coreboot.org/c/coreboot/+/37695/4/src/lib/crc_byte.c@107 
PS4, Line 107: 	0xbcb4666d, 0xb8757bda, 0xb5365d03, 0xb1f740b4
> Table-based CRC implementations are usually not worth it for firmware (we don't calculate enough of  […]

done in CB:37753