Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36416 )
Change subject: Makefile, Kconfig: Add AMD dependency for amd_blobs repo
......................................................................
Patch Set 3: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/36416/2/Makefile.inc
File Makefile.inc:
https://review.coreboot.org/c/coreboot/+/36416/2/Makefile.inc@205
PS2, Line 205: endif
Yes, meant to do that when I changed from PS1 to this.
We can still see how this turns out for mainboards using the AMD repo. If
there will be boards that only need the AMD blobs but not the general blobs
repo, we can also remove the dependency, I guess.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/36416
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4ae807659db16756453dc3db2c51848291c681b8
Gerrit-Change-Number: 36416
Gerrit-PatchSet: 3
Gerrit-Owner: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 31 Oct 2019 12:30:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Marshall Dawson
marshalldawson3rd@gmail.com
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Gerrit-MessageType: comment