Jes Klinke has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44359 )
Change subject: mainboard/google/volteer: Disable S0i3.4 if cr50 firmware is too old
......................................................................
Patch Set 20:
(1 comment)
Rebased to resolve merge conflict, PTAL.
https://review.coreboot.org/c/coreboot/+/44359/19//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/44359/19//COMMIT_MSG@29
PS19, Line 29: But it is entirely possible that
: we have just been "lucky" that the SoC has not gone into low power
: mode during the boot process, where most of the cr50 communication
: happens.
FYI, it's not necessarily luck, but likely the fact that most of the Cr50 communication happens in v […]
True, but we do still have cr50 communication when the user logs in, to mount the home directory, when new users are added, etc. All of which are after PM having been enabled.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/44359
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Idef1fffd410a345678da4b3c8aea46ac74a01470
Gerrit-Change-Number: 44359
Gerrit-PatchSet: 20
Gerrit-Owner: Jes Klinke
jbk@chromium.org
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Jes Klinke
jbk@google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 02 Sep 2020 15:51:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-MessageType: comment